messages listlengths 2 2 |
|---|
[
{
"role": "user",
"content": "Review this change in Fix: clippy, dont throw error on commas (packages/rsx/src/ifmt.rs, Rust).\n\n@@ -399,10 +391,11 @@ mod tests {\n let input = syn::parse2::<IfmtInput>(quote! { \"hello {world} {world} {world()}\" }).unwrap();\n println!(\"{}\", input.to_stri... |
[
{
"role": "user",
"content": "Review this change in Fix memo dirty flag after unrelated writes (packages/signals/tests/memo.rs, Rust).\n\n@@ -1,148 +1,178 @@\n-// TODO: fix #1935\n-\n-// #![allow(unused, non_upper_case_globals, non_snake_case)]\n-// use dioxus_core::NoOpMutations;\n-// use std::collections:... |
[
{
"role": "user",
"content": "Review this change in Fix memo dirty flag after unrelated writes (packages/signals/tests/memo.rs, Rust).\n\n@@ -1,148 +1,178 @@\n-// TODO: fix #1935\n-\n-// #![allow(unused, non_upper_case_globals, non_snake_case)]\n-// use dioxus_core::NoOpMutations;\n-// use std::collections:... |
[
{
"role": "user",
"content": "Review this change in Fix memo dirty flag after unrelated writes (packages/signals/tests/memo.rs, Rust).\n\n@@ -1,148 +1,178 @@\n-// TODO: fix #1935\n-\n-// #![allow(unused, non_upper_case_globals, non_snake_case)]\n-// use dioxus_core::NoOpMutations;\n-// use std::collections:... |
[
{
"role": "user",
"content": "Review this change in Fix: Windows File Drag-N-Drop (packages/desktop/src/webview.rs, Rust).\n\n@@ -232,10 +233,93 @@ impl WebviewInstance {\n \n let file_drop_handler = {\n to_owned![file_hover];\n- move |evt| {\n+\n+ #[cfg(windows)]\n... |
[
{
"role": "user",
"content": "Review this change in Dioxus Playground Hot Reload Support (packages/web/src/devtools.rs, Rust).\n\n@@ -237,3 +242,26 @@ pub(crate) fn invalidate_browser_asset_cache() {\n }\n }\n }\n+\n+/// Initialize required devtools for dioxus-playground.\n+///\n+/// This listen... |
[
{
"role": "user",
"content": "Review this change in Capture current scope ID in `use_muda_event_handler` (packages/desktop/src/hooks.rs, Rust).\n\n@@ -45,14 +45,18 @@ pub fn use_wry_event_handler(\n pub fn use_muda_event_handler(\n mut handler: impl FnMut(&muda::MenuEvent) + 'static,\n ) -> WryEventHand... |
[
{
"role": "user",
"content": "Review this change in SystemTray (packages/desktop/src/app.rs, Rust).\n\n@@ -134,6 +138,29 @@ impl App {\n _ => (),\n }\n }\n+ #[cfg(any(target_os = \"windows\", target_os = \"linux\", target_os = \"macos\"))]\n+ pub fn handle_tray_menu_event(&mut ... |
[
{
"role": "user",
"content": "Review this change in use DragEvent not MouseEvent for drag events (packages/web/src/events/drag.rs, Rust).\n\n@@ -4,71 +4,78 @@ use dioxus_html::{\n },\n HasDragData, HasFileData, HasMouseData,\n };\n-use web_sys::MouseEvent;\n+use wasm_bindgen::JsCast;\n+use web_sys::... |
[
{
"role": "user",
"content": "Review this change in use DragEvent not MouseEvent for drag events (packages/web/src/events/drag.rs, Rust).\n\n@@ -4,71 +4,78 @@ use dioxus_html::{\n },\n HasDragData, HasFileData, HasMouseData,\n };\n-use web_sys::MouseEvent;\n+use wasm_bindgen::JsCast;\n+use web_sys::... |
[
{
"role": "user",
"content": "Review this change in Feat: Android Dynamic Arch Support (packages/cli/src/build/request.rs, Rust).\n\n@@ -536,7 +548,13 @@ impl BuildRequest {\n .join(\"src\")\n .join(\"main\")\n .join(\"jniLibs\")\n- .join(\"arm6... |
[
{
"role": "user",
"content": "Review this change in Feat: Android Dynamic Arch Support (packages/cli/src/cli/target.rs, Rust).\n\n@@ -50,3 +50,127 @@ pub(crate) struct TargetArgs {\n #[clap(long)]\n pub(crate) target: Option<String>,\n }\n+\n+impl TargetArgs {\n+ pub(crate) fn arch(&self) -> Arch... |
[
{
"role": "user",
"content": "Review this change in Feat: Android Dynamic Arch Support (packages/cli/src/build/verify.rs, Rust).\n\n@@ -134,9 +134,19 @@ impl BuildRequest {\n /// will do its best to fill in the missing bits by exploring the sdk structure\n /// IE will attempt to use the Java install... |
[
{
"role": "user",
"content": "Review this change in Fix: `always-on-top` setting (packages/cli/src/dioxus_crate.rs, Rust).\n\n@@ -25,7 +25,7 @@ pub(crate) static PROFILE_ANDROID: &str = \"android-dev\";\n pub(crate) static PROFILE_SERVER: &str = \"server-dev\";\n \n impl DioxusCrate {"
},
{
"role": ... |
[
{
"role": "user",
"content": "Review this change in fix: throw error when asset is empty (packages/manganis/manganis-macro/src/asset.rs, Rust).\n\n@@ -19,19 +25,28 @@ fn resolve_path(raw: &str) -> Result<PathBuf, AssetParseError> {\n // /users/dioxus/dev/app/assets/blah.css\n let manifest_dir = std:... |
[
{
"role": "user",
"content": "Review this change in fix: throw error when asset is empty (packages/manganis/manganis-macro/src/asset.rs, Rust).\n\n@@ -19,19 +25,28 @@ fn resolve_path(raw: &str) -> Result<PathBuf, AssetParseError> {\n // /users/dioxus/dev/app/assets/blah.css\n let manifest_dir = std:... |
[
{
"role": "user",
"content": "Review this change in Improve server macro documentation (packages/cli/src/config/app.rs, Rust).\n\n@@ -8,8 +8,15 @@ pub(crate) struct ApplicationConfig {\n \n #[serde(default)]\n pub(crate) sub_package: Option<String>,\n+\n+ #[serde(default = \"out_dir_default\")]\n... |
[
{
"role": "user",
"content": "Review this change in Fix repeated subscription to dropped scope leak (packages/core/src/reactive_context.rs, Rust).\n\n@@ -311,3 +311,15 @@ struct Inner {\n // The scope that this reactive context is associated with\n scope: Option<ScopeId>,\n }\n+\n+impl Drop for Inne... |
[
{
"role": "user",
"content": "Review this change in Hash and compare templates by value in debug mode (packages/core/src/nodes.rs, Rust).\n\n@@ -378,17 +378,39 @@ pub struct Template {\n \n impl std::hash::Hash for Template {\n fn hash<H: std::hash::Hasher>(&self, state: &mut H) {\n- std::ptr::ha... |
[
{
"role": "user",
"content": "Review this change in Reclaim element id for all removed nodes (packages/core/src/diff/node.rs, Rust).\n\n@@ -328,6 +328,9 @@ impl VNode {\n to.remove_node(id);\n }\n dom.reclaim(id);\n+ } else {\n+ l... |
[
{
"role": "user",
"content": "Review this change in Reclaim element id for all removed nodes (packages/core/src/diff/node.rs, Rust).\n\n@@ -379,8 +382,8 @@ impl VNode {\n } else {\n to.remove_node(id);\n }\n- dom.reclaim(id)\... |
[
{
"role": "user",
"content": "Review this change in Expose Outlet Context (packages/router/src/contexts/outlet.rs, Rust).\n\n@@ -2,8 +2,34 @@ use dioxus_lib::prelude::*;\n \n use crate::{routable::Routable, utils::use_router_internal::use_router_internal};\n \n-pub(crate) struct OutletContext<R> {\n+/// A c... |
[
{
"role": "user",
"content": "Review this change in feat: Add logger to logger example (examples/logging.rs, Rust).\n\n@@ -11,10 +11,12 @@\n //!\n //! To use the dioxus logger in your app, simply call any of the tracing functions (info!(), warn!(), error!())\n \n-use dioxus::logger::tracing::{debug, error, ... |
[
{
"role": "user",
"content": "Review this change in fix(server): Provide GoogleBot compatibility. (packages/fullstack/src/server/mod.rs, Rust).\n\n@@ -374,16 +374,7 @@ impl RenderHandleState {\n pub async fn render_handler(\n State(state): State<RenderHandleState>,\n request: Request<Body>,\n-) -> i... |
[
{
"role": "user",
"content": "Review this change in Return a 404 when paring the route fails (packages/fullstack/src/render.rs, Rust).\n\n@@ -50,6 +51,11 @@ where\n }\n }\n \n+pub enum SSRError {\n+ Incremental(IncrementalRendererError),\n+ Routing(ParseRouteError),\n+}\n+"
},
{
"role": "a... |
[
{
"role": "user",
"content": "Review this change in Return a 404 when paring the route fails (packages/router/src/hooks/use_route.rs, Rust).\n\n@@ -42,7 +42,10 @@ use crate::utils::use_router_internal::use_router_internal;\n /// ```\n #[doc(alias = \"use_url\")]\n #[must_use]\n-pub fn use_route<R: Routable ... |
[
{
"role": "user",
"content": "Review this change in fix: escape backslashes in debug locations for HTMLData serialization (packages/fullstack-protocol/src/lib.rs, Rust).\n\n@@ -359,7 +359,13 @@ impl HTMLData {\n #[cfg(debug_assertions)]\n debug_types: format_js_list_of_strings(&self.... |
[
{
"role": "user",
"content": "Review this change in Clarify schedule_update docs (packages/core/src/global_context.rs, Rust).\n\n@@ -310,34 +310,38 @@ pub fn use_hook<State: Clone + 'static>(initializer: impl FnOnce() -> State) ->\n Runtime::with_current_scope(|cx| cx.use_hook(initializer)).unwrap()\n }... |
[
{
"role": "user",
"content": "Review this change in Clarify schedule_update docs (packages/core/src/global_context.rs, Rust).\n\n@@ -349,6 +353,9 @@ pub fn schedule_update() -> Arc<dyn Fn() + Send + Sync> {\n /// A component's [`ScopeId`] can be obtained from the [`current_scope_id`] method.\n ///\n /// Not... |
[
{
"role": "user",
"content": "Review this change in subsecond: Typed HotFn pointer (packages/subsecond/subsecond/src/lib.rs, Rust).\n\n@@ -284,6 +284,10 @@ pub struct HotFnPanic {\n _backtrace: backtrace::Backtrace,\n }\n \n+/// A pointer to a hot patched function\n+#[derive(PartialEq, Eq, Hash, Clone, ... |
[
{
"role": "user",
"content": "Review this change in subsecond: Typed HotFn pointer (packages/subsecond/subsecond/src/lib.rs, Rust).\n\n@@ -284,6 +284,10 @@ pub struct HotFnPanic {\n _backtrace: backtrace::Backtrace,\n }\n \n+/// A pointer to a hot patched function\n+#[derive(PartialEq, Eq, Hash, Clone, ... |
[
{
"role": "user",
"content": "Review this change in fix: symbol mismatch in object file (packages/cli/src/build/patch.rs, Rust).\n\n@@ -758,10 +758,13 @@ pub fn create_undefined_symbol_stub(\n let mut undefined_symbols = HashSet::new();\n let mut defined_symbols = HashSet::new();\n \n+ let mut s... |
[
{
"role": "user",
"content": "Review this change in fix: symbol mismatch in object file (packages/cli/src/build/patch.rs, Rust).\n\n@@ -1052,6 +1056,38 @@ pub fn create_undefined_symbol_stub(\n flags: object::SymbolFlags::None,\n });\n }\n+ SymbolK... |
[
{
"role": "user",
"content": "Review this change in Fixes issue with the file dialog showing only folders and not files (packages/desktop/src/file_upload.rs, Rust).\n\n@@ -79,7 +79,7 @@ impl FileDialogRequest {\n let filters: Vec<_> = request\n .accept\n .as_deref... |
[
{
"role": "user",
"content": "Review this change in white-list .rcgu.o files in the linking phase, otherwise dump them into the normal linking pile (packages/cli/src/build/request.rs, Rust).\n\n@@ -1704,24 +1705,30 @@ impl BuildRequest {\n }\n \n // rlibs might contai... |
[
{
"role": "user",
"content": "Review this change in Don't use inline scripts and function constructor (packages/web/src/document.rs, Rust).\n\n@@ -97,41 +96,63 @@ impl Document for WebDocument {\n \n /// Create a new meta tag in the head\n fn create_meta(&self, props: MetaProps) {\n- let myse... |
[
{
"role": "user",
"content": "Review this change in Don't use inline scripts and function constructor (packages/cli/src/build/request.rs, Rust).\n\n@@ -3936,49 +3956,13 @@ impl BuildRequest {\n \n // Manually inject the wasm file for preloading. WASM currently doesn't support preloading in the manga... |
[
{
"role": "user",
"content": "Review this change in Fix form submission on native if there is an onclick handler somewhere (packages/interpreter/src/ts/native.ts, TypeScript).\n\n@@ -277,11 +277,14 @@ export class NativeInterpreter extends JSChannel_ {\n bubbles,\n };\n \n- // Run any prevent d... |
[
{
"role": "user",
"content": "Review this change in Enhance CLI Build Duration Output with Human-Readable Formatting (packages/cli/src/serve/runner.rs, Rust).\n\n@@ -578,13 +578,17 @@ impl AppServer {\n \n if self.client.builds_opened == 0 {\n tracing::info!(\n- ... |
[
{
"role": "user",
"content": "Review this change in Enhance CLI Build Duration Output with Human-Readable Formatting (packages/cli/src/serve/runner.rs, Rust).\n\n@@ -578,13 +578,17 @@ impl AppServer {\n \n if self.client.builds_opened == 0 {\n tracing::info!(\n- ... |
[
{
"role": "user",
"content": "Review this change in Look for strip settings in inherited profiles and global configs (packages/cli/src/cargo_toml.rs, Rust).\n\n@@ -0,0 +1,147 @@\n+//! The cargo_toml crate contains some logic for resolving Cargo.toml files with workspace inheritance, but it\n+//! doesn't han... |
[
{
"role": "user",
"content": "Review this change in restore the extract function for server functions (packages/fullstack-core/src/streaming.rs, Rust).\n\n@@ -56,17 +91,24 @@ impl FullstackContext {\n }\n \n /// Access the http request parts mutably. This will allow you to modify headers and other p... |
[
{
"role": "user",
"content": "Review this change in Resolves #5045: Trim slashes to prevent base path resolution issues in web (packages/cli/src/build/request.rs, Rust).\n\n@@ -4899,7 +4902,10 @@ __wbg_init({{module_or_path: \"/{}/{wasm_path}\"}}).then((wasm) => {{\n // Add the base path to the hea... |
[
{
"role": "user",
"content": "Review this change in fix: replace unwraps with errors in fullstack WebSockets (packages/fullstack-core/src/error.rs, Rust).\n\n@@ -312,3 +312,60 @@ impl RequestError {\n }\n }\n }\n+\n+impl From<reqwest::Error> for RequestError {\n+ fn from(value: reqwest::Error... |
[
{
"role": "user",
"content": "Review this change in Simplify and fix some issues with `#[component]` macro (packages/core-macro/src/component.rs, Rust).\n\n@@ -11,7 +11,7 @@ pub struct ComponentBody {\n impl Parse for ComponentBody {\n fn parse(input: ParseStream) -> Result<Self> {\n let item_fn... |
[
{
"role": "user",
"content": "Review this change in Improve the base_path story (packages/router/src/history/web.rs, Rust).\n\n@@ -74,7 +74,9 @@ impl<R: Routable> WebHistory<R> {\n let myself = Self::new_inner(prefix, do_scroll_restoration);\n \n let current_route = myself.current_route();\n... |
[
{
"role": "user",
"content": "Review this change in Add the `onresize` event handler to Element (packages/html/src/events/resize.rs, Rust).\n\n@@ -0,0 +1,168 @@\n+use std::fmt::{Display, Formatter};\n+\n+pub struct ResizeData {\n+ inner: Box<dyn HasResizeData>,\n+}\n+\n+impl<E: HasResizeData> From<E> for... |
[
{
"role": "user",
"content": "Review this change in TUI tweaks (packages/cli/src/serve/mod.rs, Rust).\n\n@@ -67,7 +67,7 @@ pub async fn serve_all(serve: Serve, dioxus_crate: DioxusCrate) -> Result<()> {\n // rebuild the project or hotreload it\n _ = watcher.wait() => {\n ... |
[
{
"role": "user",
"content": "Review this change in Fix: clippy, dont throw error on commas (packages/rsx/src/rsx_block.rs, Rust).\n\n@@ -224,16 +224,30 @@ impl RsxBlock {\n // Parse a body node with diagnostics for unnecessary trailing commas\n fn parse_body_node_with_comma_diagnostics(\n c... |
[
{
"role": "user",
"content": "Review this change in Fix memo dirty flag after unrelated writes (packages/signals/src/memo.rs, Rust).\n\n@@ -139,10 +139,11 @@ impl<T: 'static> Memo<T> {\n drop(peak);\n let mut copy = self.inner;\n copy.set(new_value);\n- update_... |
[
{
"role": "user",
"content": "Review this change in Fix: Windows File Drag-N-Drop (packages/interpreter/src/ts/native.ts, TypeScript).\n\n@@ -167,6 +167,47 @@ export class NativeInterpreter extends JSChannel_ {\n }\n }\n \n+ // Windows drag-n-drop fix code. Called by wry drag-n-drop handler over the ... |
[
{
"role": "user",
"content": "Review this change in SystemTray (packages/desktop/src/trayicon.rs, Rust).\n\n@@ -0,0 +1,68 @@\n+//! tray icon\n+\n+use dioxus_core::{\n+ prelude::{provide_context, try_consume_context},\n+ use_hook,\n+};\n+\n+#[cfg(not(any(target_os = \"ios\", target_os = \"android\")))]... |
[
{
"role": "user",
"content": "Review this change in use DragEvent not MouseEvent for drag events (packages/web/src/events/mouse.rs, Rust).\n\n@@ -5,7 +5,7 @@ use dioxus_html::{\n InteractionElementOffset, InteractionLocation, Modifiers, ModifiersInteraction,\n PointerInteraction,\n },\n-... |
[
{
"role": "user",
"content": "Review this change in Feat: Android Dynamic Arch Support (packages/cli/src/dioxus_crate.rs, Rust).\n\n@@ -557,7 +557,7 @@ impl DioxusCrate {\n krates\n }\n \n- fn android_ndk(&self) -> Option<PathBuf> {\n+ pub(crate) fn android_ndk(&self) -> Option<PathBuf> {\... |
[
{
"role": "user",
"content": "Review this change in Feat: Manganis SCSS Support (packages/cli-opt/src/css.rs, Rust).\n\n@@ -1,11 +1,14 @@\n use std::path::Path;\n \n use anyhow::Context;\n+use codemap::SpanLoc;\n+use grass::OutputStyle;\n use lightningcss::{\n printer::PrinterOptions,\n stylesheet::... |
[
{
"role": "user",
"content": "Review this change in Fix: `always-on-top` setting (packages/cli/src/serve/handle.rs, Rust).\n\n@@ -70,13 +70,19 @@ impl AppHandle {\n start_fullstack_on_address: Option<SocketAddr>,\n open_browser: bool,\n ) -> Result<()> {\n+ let krate = &self.app.b... |
[
{
"role": "user",
"content": "Review this change in Improve server macro documentation (packages/server-macro/src/lib.rs, Rust).\n\n@@ -31,23 +31,85 @@ use syn::{__private::ToTokens, parse_quote};\n ///\n /// ## Named Arguments\n ///\n-/// You can any combination of the following named arguments:\n+/// You ... |
[
{
"role": "user",
"content": "Review this change in Hash and compare templates by value in debug mode (packages/router/tests/via_ssr/navigation.rs, Rust).\n\n@@ -0,0 +1,69 @@\n+use dioxus::prelude::*;\n+use dioxus_core::NoOpMutations;\n+use std::sync::atomic::AtomicUsize;\n+\n+// Regression test for <https:... |
[
{
"role": "user",
"content": "Review this change in Reclaim element id for all removed nodes (packages/core/tests/diff_unkeyed_list.rs, Rust).\n\n@@ -149,13 +149,13 @@ fn removes_one_by_one() {\n dom.render_immediate_to_vec().edits,\n [\n LoadTemplate { index: 0, id: ElementId(2)... |
[
{
"role": "user",
"content": "Review this change in Expose Outlet Context (packages/router/src/components/router.rs, Rust).\n\n@@ -47,11 +47,10 @@ where\n \n use_hook(|| {\n provide_router_context(RouterContext::new(props.config.call(())));\n+ });\n \n- provide_context(OutletContext::<... |
[
{
"role": "user",
"content": "Review this change in Return a 404 when paring the route fails (packages/playwright-tests/fullstack-routing/src/main.rs, Rust).\n\n@@ -0,0 +1,54 @@\n+// This test is used by playwright configured in the root of the repo\n+// Tests:\n+// - 200 Routes\n+// - 404 Routes\n+// - 500... |
[
{
"role": "user",
"content": "Review this change in Clarify schedule_update docs (packages/core/src/scope_context.rs, Rust).\n\n@@ -145,9 +145,13 @@ impl Scope {\n .expect(\"Scheduler to exist if scope exists\");\n }\n \n- /// Create a subscription that schedules a future render for the r... |
[
{
"role": "user",
"content": "Review this change in subsecond: Typed HotFn pointer (packages/core/src/properties.rs, Rust).\n\n@@ -155,7 +155,7 @@ where\n }\n \n fn fn_ptr(&self) -> usize {\n- subsecond::HotFn::current(self.clone()).ptr_address() as usize\n+ subsecond::HotFn::current(s... |
[
{
"role": "user",
"content": "Review this change in fix: symbol mismatch in object file (packages/subsecond/subsecond/src/lib.rs, Rust).\n\n@@ -64,7 +64,17 @@\n //! Subsecond is only enabled when debug_assertions are enabled so you can safely ship your application\n //! with Subsecond enabled without worry... |
[
{
"role": "user",
"content": "Review this change in Switch to owned listener type (packages/core/src/events.rs, Rust).\n\n@@ -1,6 +1,8 @@\n-use crate::{properties::SuperFrom, runtime::RuntimeGuard, Runtime, ScopeId};\n+use crate::{\n+ prelude::current_scope_id, properties::SuperFrom, runtime::RuntimeGuar... |
[
{
"role": "user",
"content": "Review this change in Fix form submission on native if there is an onclick handler somewhere (examples/form.rs, Rust).\n\n@@ -132,5 +132,11 @@ fn app() -> Element {\n pre { \"{values:#?}\" }\n }\n }\n+ button {\n+ onclick: m... |
[
{
"role": "user",
"content": "Review this change in Look for strip settings in inherited profiles and global configs (packages/cli/src/build/request.rs, Rust).\n\n@@ -326,6 +326,7 @@ use crate::{\n };\n use anyhow::{bail, Context};\n use cargo_metadata::diagnostic::Diagnostic;\n+use cargo_toml::{Profile, Pr... |
[
{
"role": "user",
"content": "Review this change in restore the extract function for server functions (packages/fullstack-server/src/serverfn.rs, Rust).\n\n@@ -2,7 +2,7 @@ use axum::body::Body;\n use axum::routing::MethodRouter;\n use axum::Router;\n use dashmap::DashMap;\n-use dioxus_fullstack_core::Dioxus... |
[
{
"role": "user",
"content": "Review this change in fix(cli): queue file changes that arrive during builds instead of dropping them (packages/cli/src/serve/runner.rs, Rust).\n\n@@ -81,6 +81,9 @@ pub(crate) struct AppServer {\n \n // Additional plugin-type tools\n pub(crate) tw_watcher: tokio::task::... |
[
{
"role": "user",
"content": "Review this change in Resolves #5045: Trim slashes to prevent base path resolution issues in web (packages/cli/src/build/builder.rs, Rust).\n\n@@ -521,7 +521,7 @@ impl AppBuilder {\n envs.push((\"RUST_BACKTRACE\".into(), \"1\".to_string()));\n }\n \n- ... |
[
{
"role": "user",
"content": "Review this change in Full file paths in drop handlers (packages/desktop/src/webview.rs, Rust).\n\n@@ -13,7 +13,7 @@ use dioxus_core::{consume_context, provide_context, Runtime, ScopeId, VirtualDom\n use dioxus_document::Document;\n use dioxus_history::{History, MemoryHistory};... |
[
{
"role": "user",
"content": "Review this change in Dialog: Fix close bug (#15000) (packages/dialog/src/component.vue, Vue).\n\n@@ -3,15 +3,16 @@\n name=\"dialog-fade\"\n @after-enter=\"afterEnter\"\n @after-leave=\"afterLeave\">\n- <div class=\"el-dialog__wrapper\" v-show=\"visible\" @click.... |
[
{
"role": "user",
"content": "Review this change in on linux don't declare we installed to the system store (truststore_linux.go, Go).\n\n@@ -17,7 +17,8 @@ var (\n )\n \n func (m *mkcert) installPlatform() {\n-\tlog.Fatalf(\"-install is not yet supported on Linux 😣\\nYou can manually install the root certi... |
[
{
"role": "user",
"content": "Review this change in support install into java cacerts file (main.go, Go).\n\n@@ -178,6 +182,11 @@ func (m *mkcert) install() {\n \t\t}\n \t\tprinted = true\n \t}\n+\tif hasJava && !m.checkJava() {\n+\t\tm.installJava()"
},
{
"role": "assistant",
"content": "Commen... |
[
{
"role": "user",
"content": "Review this change in support install into java cacerts file (truststore_java.go, Go).\n\n@@ -0,0 +1,121 @@\n+package main\n+\n+import (\n+\t\"bytes\"\n+\t\"crypto/sha1\"\n+\t\"crypto/sha256\"\n+\t\"crypto/x509\"\n+\t\"encoding/hex\"\n+\t\"encoding/pem\"\n+\t\"fmt\"\n+\t\"hash\... |
[
{
"role": "user",
"content": "Review this change in support install into java cacerts file (truststore_java.go, Go).\n\n@@ -0,0 +1,121 @@\n+package main\n+\n+import (\n+\t\"bytes\"\n+\t\"crypto/sha1\"\n+\t\"crypto/sha256\"\n+\t\"crypto/x509\"\n+\t\"encoding/hex\"\n+\t\"encoding/pem\"\n+\t\"fmt\"\n+\t\"hash\... |
[
{
"role": "user",
"content": "Review this change in support install into java cacerts file (truststore_java.go, Go).\n\n@@ -0,0 +1,121 @@\n+package main\n+\n+import (\n+\t\"bytes\"\n+\t\"crypto/sha1\"\n+\t\"crypto/sha256\"\n+\t\"crypto/x509\"\n+\t\"encoding/hex\"\n+\t\"encoding/pem\"\n+\t\"fmt\"\n+\t\"hash\... |
[
{
"role": "user",
"content": "Review this change in support install into java cacerts file (truststore_java.go, Go).\n\n@@ -0,0 +1,121 @@\n+package main\n+\n+import (\n+\t\"bytes\"\n+\t\"crypto/sha1\"\n+\t\"crypto/sha256\"\n+\t\"crypto/x509\"\n+\t\"encoding/hex\"\n+\t\"encoding/pem\"\n+\t\"fmt\"\n+\t\"hash\... |
[
{
"role": "user",
"content": "Review this change in support install into java cacerts file (truststore_java.go, Go).\n\n@@ -0,0 +1,121 @@\n+package main\n+\n+import (\n+\t\"bytes\"\n+\t\"crypto/sha1\"\n+\t\"crypto/sha256\"\n+\t\"crypto/x509\"\n+\t\"encoding/hex\"\n+\t\"encoding/pem\"\n+\t\"fmt\"\n+\t\"hash\... |
[
{
"role": "user",
"content": "Review this change in support install into java cacerts file (truststore_java.go, Go).\n\n@@ -0,0 +1,121 @@\n+package main\n+\n+import (\n+\t\"bytes\"\n+\t\"crypto/sha1\"\n+\t\"crypto/sha256\"\n+\t\"crypto/x509\"\n+\t\"encoding/hex\"\n+\t\"encoding/pem\"\n+\t\"fmt\"\n+\t\"hash\... |
[
{
"role": "user",
"content": "Review this change in support install into java cacerts file (truststore_java.go, Go).\n\n@@ -0,0 +1,106 @@\n+package main\n+\n+import (\n+\t\"bytes\"\n+\t\"crypto/sha1\"\n+\t\"crypto/sha256\"\n+\t\"crypto/x509\"\n+\t\"encoding/hex\"\n+\t\"hash\"\n+\t\"os\"\n+\t\"os/exec\"\n+\t... |
[
{
"role": "user",
"content": "Review this change in Use $XDG_DATA_HOME on macOS if it is set. (main.go, Go).\n\n@@ -131,32 +131,30 @@ print it with \"mkcert -CAROOT\".\n \tm.makeCert(args)\n }\n \n+func getCAROOTFolder() string {\n+\tif runtime.GOOS == \"windows\" {\n+\t\treturn os.Getenv(\"LocalAppData\")\... |
[
{
"role": "user",
"content": "Review this change in Add Windows Support (truststore_windows.go, Go).\n\n@@ -0,0 +1,129 @@\n+package main\n+\n+import (\n+\t\"crypto/x509\"\n+\t\"encoding/pem\"\n+\t\"fmt\"\n+\t\"io/ioutil\"\n+\t\"os\"\n+\t\"path/filepath\"\n+\t\"syscall\"\n+\t\"unsafe\"\n+)\n+\n+var (\n+\tFir... |
[
{
"role": "user",
"content": "Review this change in java: fix keytool path detection on windows and JRE/JDK (truststore_java.go, Go).\n\n@@ -29,14 +30,19 @@ var (\n )\n \n func init() {\n+\tkeytoolPath = \"bin/keytool\"\n+\tif runtime.GOOS == \"windows\" {\n+\t\tkeytoolPath += \".exe\"\n+\t}\n+\n \tif v := ... |
[
{
"role": "user",
"content": "Review this change in Add ability of customizing file name (cert.go, Go).\n\n@@ -39,6 +40,34 @@ func init() {\n \tuserAndHostname += strings.TrimSpace(string(out))\n }\n \n+// getFileName generate file name according to flags\n+func (m *mkcert) getFileName(w string, args []stri... |
[
{
"role": "user",
"content": "Review this change in Add ability of customizing file name (cert.go, Go).\n\n@@ -111,9 +140,9 @@ func (m *mkcert) makeCert(hosts []string) {\n \t}\n \n \tif !m.pkcs12 {\n-\t\tlog.Printf(\"\\nThe certificate is at \\\"./%s.pem\\\" and the key at \\\"./%s-key.pem\\\" ✅\\n\\n\", f... |
[
{
"role": "user",
"content": "Review this change in Add support for certificates with client and server auth and URL SANs (main.go, Go).\n\n@@ -194,6 +195,9 @@ func (m *mkcert) Run(args []string) {\n \t\tif email, err := mail.ParseAddress(name); err == nil && email.Address == name {\n \t\t\tcontinue\n \t\t}... |
[
{
"role": "user",
"content": "Review this change in Add support for certificates with client and server auth and URL SANs (main.go, Go).\n\n@@ -194,6 +195,9 @@ func (m *mkcert) Run(args []string) {\n \t\tif email, err := mail.ParseAddress(name); err == nil && email.Address == name {\n \t\t\tcontinue\n \t\t}... |
[
{
"role": "user",
"content": "Review this change in Add support for certificates with client and server auth and URL SANs (cert.go, Go).\n\n@@ -70,13 +71,15 @@ func (m *mkcert) makeCert(hosts []string) {\n \t\t\ttpl.IPAddresses = append(tpl.IPAddresses, ip)\n \t\t} else if email, err := mail.ParseAddress(h)... |
[
{
"role": "user",
"content": "Review this change in Add support for certificates with client and server auth and URL SANs (main.go, Go).\n\n@@ -194,13 +195,16 @@ func (m *mkcert) Run(args []string) {\n \t\tif email, err := mail.ParseAddress(name); err == nil && email.Address == name {\n \t\t\tcontinue\n \t\... |
[
{
"role": "user",
"content": "Review this change in Add support for certificates with client and server auth and URL SANs (main.go, Go).\n\n@@ -194,13 +195,16 @@ func (m *mkcert) Run(args []string) {\n \t\tif email, err := mail.ParseAddress(name); err == nil && email.Address == name {\n \t\t\tcontinue\n \t\... |
[
{
"role": "user",
"content": "Review this change in Don't overwrite the -key-file if it's identical to -cert-file (cert.go, Go).\n\n@@ -108,15 +108,26 @@ func (m *mkcert) makeCert(hosts []string) {\n \tcertFile, keyFile, p12File := m.fileNames(hosts)"
},
{
"role": "assistant",
"content": "Commen... |
[
{
"role": "user",
"content": "Review this change in on linux don't declare we installed to the system store (main.go, Go).\n\n@@ -154,8 +154,13 @@ func (m *mkcert) install() {\n \tvar printed bool\n \tif !m.checkPlatform() {\n \t\tm.installPlatform()\n-\t\tm.ignoreCheckFailure = true // TODO: replace with a... |
[
{
"role": "user",
"content": "Review this change in Add ability of customizing file name (main.go, Go).\n\n@@ -40,6 +40,8 @@ const usage = `Usage of mkcert:\n \t$ mkcert -uninstall\n \tUninstall the local CA (but do not delete it).\n \n+Use -cert-file, -key-file and -p12-file to customize the output paths.\... |
[
{
"role": "user",
"content": "Review this change in Improve Parallelism & Fix Bugs After Testing (lightrag/lightrag.py, Python).\n\n@@ -431,37 +428,22 @@ async def ainsert_custom_chunks(self, full_text: str, text_chunks: list[str]):\n \"full_doc_id\": doc_key,\n }\n \n- ... |
[
{
"role": "user",
"content": "Review this change in Improve Parallelism & Fix Bugs After Testing (lightrag/lightrag.py, Python).\n\n@@ -600,50 +563,39 @@ async def apipeline_process_enqueue_documents(\n )\n }\n \n- # Ensure chunk insertion and graph process... |
[
{
"role": "user",
"content": "Review this change in API insert Texts, Improvement stream and naming (lightrag/api/lightrag_server.py, Python).\n\n@@ -626,98 +625,158 @@ def is_supported_file(self, filename: str) -> bool:\n return any(filename.lower().endswith(ext) for ext in self.supported_extension... |
[
{
"role": "user",
"content": "Review this change in API insert Texts, Improvement stream and naming (lightrag/api/lightrag_server.py, Python).\n\n@@ -626,98 +625,158 @@ def is_supported_file(self, filename: str) -> bool:\n return any(filename.lower().endswith(ext) for ext in self.supported_extension... |
[
{
"role": "user",
"content": "Review this change in API insert Texts, Improvement stream and naming (lightrag/api/lightrag_server.py, Python).\n\n@@ -626,98 +625,158 @@ def is_supported_file(self, filename: str) -> bool:\n return any(filename.lower().endswith(ext) for ext in self.supported_extension... |
[
{
"role": "user",
"content": "Review this change in Fixed broken ainsert_custom_kg() (lightrag/lightrag.py, Python).\n\n@@ -859,11 +860,18 @@ async def ainsert_custom_kg(self, custom_kg: dict[str, Any]):\n all_chunks_data: dict[str, dict[str, str]] = {}\n chunk_to_source_map: dict[st... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.